Skip to content

OCPBUGS-13547: remove special cases for featureset in rendering #7158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 11, 2023
Merged

OCPBUGS-13547: remove special cases for featureset in rendering #7158

openshift-merge-robot merged 1 commit into from
May 11, 2023

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented May 3, 2023

This completes the reset for rendering featureset sensitive manifests based on the FeatureGate manifest provided by the cluster-config-operator.

@deads2k
Copy link
Contributor Author

deads2k commented May 3, 2023

  • could not run steps: step installer-artifacts failed: error occurred handling build installer-artifacts: build didn't start running within 30m0s (phase: Running):
    Found 17 events for Pod installer-artifacts-build:

/retest

@patrickdillon
Copy link
Contributor

patrickdillon commented May 3, 2023

  • could not run steps: step installer-artifacts failed: error occurred handling build installer-artifacts: build didn't start running within 30m0s (phase: Running):
    Found 17 events for Pod installer-artifacts-build:

/retest

Revert for the cause is being floated here: openshift/ci-tools#3409

I'm also floating #7159 for discussion.

@deads2k
Copy link
Contributor Author

deads2k commented May 3, 2023

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented May 3, 2023

/retest

patrickdillon
patrickdillon reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about the relationship between this and #7152. Do we still need this?

data/data/bootstrap/files/usr/local/bin/bootkube.sh.template Outdated
Comment on lines -92 to -97
Copy link
Contributor

@patrickdillon patrickdillon May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting these three lines is not covered by #7152

Copy link
Contributor Author

@deads2k deads2k May 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, trying to remove the --feature-set from our render commands. #7152 is more important, but this is also desired

@deads2k deads2k force-pushed the remove-old-feature-set branch from 3e6b457 to e1f2157 Compare May 8, 2023 17:41
@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 10, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented May 10, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@deads2k deads2k added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 11, 2023
@deads2k
Copy link
Contributor Author

deads2k commented May 11, 2023

last installer change for the cluster-config-operator. MCO may need a rendering flag passed. Adding label.

A secondary benefit of this approach is that we now have a way to pass the config.openshift.io resources to rendering without individual flags for each render command. This is a good approach to solving the disparate flag sprawl and moving towards contract stability.

@deads2k
Copy link
Contributor Author

deads2k commented May 11, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 11, 2023

/retest-required

Remaining retests: 0 against base HEAD 4599c85 and 2 for PR HEAD e1f2157 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade e1f2157 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn e1f2157 link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2834d19 into openshift:master May 11, 2023
@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 15, 2023

@deads2k This broke the feature gate manifest generation process and I think has broken installations.

While the manifest file path you removed here has a full path when it writes out, the paths for the feature gate files found by the generic/path walk approach we have, return a relative path to the rendered path, so when we write out using OriginalFileName it writes the file directly to CWD rather than the original path. Any idea why original file name shouldn't be the absolute path?

@JoelSpeed JoelSpeed mentioned this pull request May 15, 2023
Merged
@stbenjam stbenjam mentioned this pull request May 15, 2023
Merged
@deads2k deads2k mentioned this pull request May 16, 2023
Merged
@deads2k deads2k changed the title remove special cases for featureset in rendering OCPBUGS-13547: remove special cases for featureset in rendering May 16, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2023

@deads2k: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state.

Details

In response to this:

This completes the reset for rendering featureset sensitive manifests based on the FeatureGate manifest provided by the cluster-config-operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deads2k @patrickdillon @JoelSpeed @openshift-ci-robot @openshift-merge-robot